preserving the capacity of the Symbols slice during resets#7404
Merged
friedrichg merged 4 commits intocortexproject:masterfrom Apr 25, 2026
Merged
Conversation
SungJin1212
commented
Apr 17, 2026
| // v1 request is put back into the pool by the Distributor. | ||
| defer func() { | ||
| cortexpb.ReuseWriteRequestV2(&req) | ||
| req.Free() |
Member
Author
There was a problem hiding this comment.
Delete the req.Free() since this path is a http.
SungJin1212
commented
Apr 17, 2026
| } | ||
|
|
||
| var req cortexpb.PreallocWriteRequestV2 | ||
| req := cortexpb.PreallocWriteRequestV2FromPool() |
Member
Author
There was a problem hiding this comment.
Use a req from the pool to reuse the capacity of the Symbols.
SungJin1212
commented
Apr 17, 2026
Comment on lines
+133
to
+140
| // Reset implements proto.Message and preserves the capacity of the Symbols slice. | ||
| func (p *PreallocWriteRequestV2) Reset() { | ||
| savedSymbols := p.Symbols | ||
| p.WriteRequestV2.Reset() | ||
| p.Symbols = savedSymbols[:0] | ||
| p.data = nil | ||
| } | ||
|
|
Member
Author
There was a problem hiding this comment.
Override a Reset() to preserve the capacity of the Symbols.
SungJin1212
force-pushed
the
preserve-capacity-symbols-in-resets
branch
from
c4cc846 to
402e968
Compare
SungJin1212
force-pushed
the
preserve-capacity-symbols-in-resets
branch
2 times, most recently
from
ab91623 to
e8fa471
Compare
Member
|
I ran some quick benchmarks and a saw only 5% improvement in latency and 10% less memory. |
Signed-off-by: SungJin1212 <tjdwls1201@gmail.com>
Signed-off-by: SungJin1212 <tjdwls1201@gmail.com>
SungJin1212
force-pushed
the
preserve-capacity-symbols-in-resets
branch
from
c09ea3e to
c581065
Compare
Signed-off-by: SungJin1212 <tjdwls1201@gmail.com>
SungJin1212
force-pushed
the
preserve-capacity-symbols-in-resets
branch
from
c581065 to
6054dee
Compare
Member
Author
|
@friedrichg |
This comment was marked as low quality.
This comment was marked as low quality.
Sorry, something went wrong.
friedrichg
approved these changes
Apr 25, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR optimizes memory allocations in the PRW2 path.
Reset()method to thePreallocWriteRequestV2object that clears the fields while preserving the underlying memory capacity of the Symbols slice.PreallocWriteRequestV2FromPool().Which issue(s) this PR fixes:
Fixes #
Checklist
CHANGELOG.mdupdated - the order of entries should be[CHANGE],[FEATURE],[ENHANCEMENT],[BUGFIX]